Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API phpunit 9 support #101

Merged
merged 1 commit into from
Nov 9, 2021
Merged

API phpunit 9 support #101

merged 1 commit into from
Nov 9, 2021

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Nov 5, 2021
Closed
93 tasks
@emteknetnz emteknetnz force-pushed the pulls/2/sapphire-test-nine branch from a1695e3 to b696fb6 Compare November 5, 2021 01:10
maxime-rainville
maxime-rainville requested changes Nov 8, 2021
View reviewed changes
Copy link

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still trying to test PHP 7.1 and 7.2.

There's one test failure on the other supported PHP version which may or may not be related to this PR.

@emteknetnz emteknetnz force-pushed the pulls/2/sapphire-test-nine branch 2 times, most recently from 3f2b200 to 11e98ab Compare November 8, 2021 22:17
@emteknetnz emteknetnz force-pushed the pulls/2/sapphire-test-nine branch from 11e98ab to 2eca7d0 Compare November 9, 2021 01:09
maxime-rainville
maxime-rainville approved these changes Nov 9, 2021
View reviewed changes
Copy link

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxime-rainville maxime-rainville merged commit b0cfcc3 into silverstripe:2 Nov 9, 2021
@maxime-rainville maxime-rainville deleted the pulls/2/sapphire-test-nine branch November 9, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-rainville maxime-rainville maxime-rainville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @maxime-rainville